-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Implement comprehensive Trustpilot webhooks and review management #17613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Implement comprehensive Trustpilot webhooks and review management #17613
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@seynadio is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update introduces a comprehensive Trustpilot integration, including a fully implemented app interface, reusable constants and utilities, and a suite of new actions and polling-based sources for reviews, replies, and conversations. The integration supports fetching, replying, and monitoring both service and product reviews, with robust error handling, pagination, and deduplication logic. Additionally, a Freshdesk action and method for adding notes to tickets were added. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action/Source
participant TrustpilotApp
participant TrustpilotAPI
User->>Action/Source: Trigger (manual or scheduled)
Action/Source->>TrustpilotApp: Call API method (e.g., getServiceReviews)
TrustpilotApp->>TrustpilotAPI: HTTP request (with auth, params)
TrustpilotAPI-->>TrustpilotApp: API response (reviews, replies, etc.)
TrustpilotApp-->>Action/Source: Parsed data or error
alt Action
Action-->>User: Return data/result or error
else Source
Action/Source->>Action/Source: Deduplicate/filter new/updated items
Action/Source-->>User: Emit event with summary and metadata
end
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/freshdesk/actions/add-note-to-ticket/add-note-to-ticket.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/freshdesk/freshdesk.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
🧹 Nitpick comments (3)
components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs (1)
30-48
: Consider enhancing error context.The error handling is functional but could provide more context about the specific failure mode.
} catch (error) { - throw new Error(`Failed to fetch service review: ${error.message}`); + throw new Error(`Failed to fetch service review ${reviewId} for business unit ${businessUnitId}: ${error.message}`); }components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs (1)
49-62
: Consider adding message length validation.While the empty message validation is good, consider adding a maximum length validation to prevent API errors from overly long messages.
if (!message || message.trim().length === 0) { throw new Error("Reply message cannot be empty"); } + + if (message.trim().length > 1000) { // Adjust limit based on Trustpilot API + throw new Error("Reply message exceeds maximum length"); + }components/trustpilot/app/trustpilot.app.ts (1)
65-68
: Consider improving the label formatting for better readability.The current label generation produces labels like "created at desc". Consider enhancing the formatting for better user experience.
- label: key.replace(/_/g, " ").toLowerCase(), + label: key.replace(/_/g, " ").toLowerCase().replace(/\b\w/g, l => l.toUpperCase()).replace(/\s(asc|desc)$/i, (match, dir) => ` (${dir.toUpperCase()})`),This would produce labels like "Created At (DESC)" which is more readable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (18)
components/trustpilot/.gitignore
(0 hunks)components/trustpilot/actions/fetch-product-review-by-id/fetch-product-review-by-id.mjs
(1 hunks)components/trustpilot/actions/fetch-product-reviews/fetch-product-reviews.mjs
(1 hunks)components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs
(1 hunks)components/trustpilot/actions/fetch-service-reviews/fetch-service-reviews.mjs
(1 hunks)components/trustpilot/actions/reply-to-product-review/reply-to-product-review.mjs
(1 hunks)components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs
(1 hunks)components/trustpilot/app/trustpilot.app.ts
(1 hunks)components/trustpilot/common/constants.mjs
(1 hunks)components/trustpilot/common/utils.mjs
(1 hunks)components/trustpilot/package.json
(1 hunks)components/trustpilot/sources/common/webhook.mjs
(1 hunks)components/trustpilot/sources/invitation-failed/invitation-failed.mjs
(1 hunks)components/trustpilot/sources/invitation-sent/invitation-sent.mjs
(1 hunks)components/trustpilot/sources/reply-created/reply-created.mjs
(1 hunks)components/trustpilot/sources/review-created/review-created.mjs
(1 hunks)components/trustpilot/sources/review-deleted/review-deleted.mjs
(1 hunks)components/trustpilot/sources/review-revised/review-revised.mjs
(1 hunks)
💤 Files with no reviewable changes (1)
- components/trustpilot/.gitignore
🧰 Additional context used
🧠 Learnings (13)
components/trustpilot/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/trustpilot/sources/review-deleted/review-deleted.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/trustpilot/actions/reply-to-product-review/reply-to-product-review.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/trustpilot/actions/fetch-service-reviews/fetch-service-reviews.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/trustpilot/sources/review-created/review-created.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trustpilot/sources/common/webhook.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The `processTimerEvent` method in the `components/salesforce_rest_api/sources/common.mjs` file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
components/trustpilot/sources/invitation-failed/invitation-failed.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/trustpilot/sources/review-revised/review-revised.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trustpilot/sources/reply-created/reply-created.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trustpilot/sources/invitation-sent/invitation-sent.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/trustpilot/common/constants.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trustpilot/app/trustpilot.app.ts (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
🔇 Additional comments (30)
components/trustpilot/package.json (1)
15-15
: LGTM! JSON structure fix is correct.The missing closing brace for the
publishConfig
object has been properly added.components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs (1)
1-23
: LGTM! Action structure follows Pipedream conventions.The import, property definitions, and overall structure are well-implemented and consistent with Pipedream action patterns.
components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs (2)
36-38
: Excellent input validation.The validation for empty or whitespace-only messages is a good practice that prevents API errors and improves user experience.
40-48
: Good implementation with proper message trimming.The message trimming before sending the API request and the summary formatting are well-implemented.
components/trustpilot/sources/review-deleted/review-deleted.mjs (2)
1-16
: LGTM! Webhook source follows proper patterns.The extension of the common webhook base and event specification are correctly implemented.
17-22
: Excellent defensive programming with fallback handling.The fallback to "Anonymous" for missing consumer display names is a good practice that prevents summary generation errors.
components/trustpilot/sources/reply-created/reply-created.mjs (2)
1-16
: LGTM! Consistent webhook source implementation.The extension of the common webhook base and event specification follow the established pattern correctly.
17-24
: Good text truncation logic for preview.The 50-character truncation with ellipsis provides a good balance between preview content and summary length, improving readability in event streams.
components/trustpilot/actions/reply-to-product-review/reply-to-product-review.mjs (4)
29-31
: Good validation logic for empty messages.The validation correctly checks for both null/undefined and whitespace-only messages, preventing empty replies from being sent.
39-39
: Summary format follows best practices.The summary message format correctly follows the learned pattern: "Successfully [action] [details]" which provides clear feedback to users.
41-49
: Comprehensive return object with useful metadata.The returned object includes success flag, API response, and metadata with review ID, message length, and timestamp - all valuable for debugging and workflow integration.
50-52
: Proper error handling with descriptive messages.The error handling correctly wraps the original error message in a more descriptive context, making it easier to diagnose issues.
components/trustpilot/sources/review-revised/review-revised.mjs (2)
4-5
: Proper extension of common webhook base.The spread operator correctly extends the common webhook functionality, following the established pattern for webhook sources.
17-23
: Good summary generation with fallback values.The summary generation correctly extracts review data and provides appropriate fallback values ("N/A" for stars, "Anonymous" for consumer name) when data is missing, ensuring robust handling of incomplete webhook payloads.
components/trustpilot/actions/fetch-product-review-by-id/fetch-product-review-by-id.mjs (1)
18-38
: Well-structured fetch action with proper error handling.The implementation correctly follows the standard pattern for fetch actions: extract parameters, call API method, export summary, and return data with metadata. The error handling provides descriptive messages and the summary format follows best practices.
components/trustpilot/actions/fetch-service-reviews/fetch-service-reviews.mjs (3)
53-60
: Good validation constraints on custom offset prop.The offset prop correctly includes validation constraints (min: 0) and a sensible default value (0), preventing invalid pagination parameters.
86-88
: Proper response destructuring and summary format.The response is correctly destructured into reviews and pagination, and the summary message follows the learned pattern by including the count of fetched reviews.
90-104
: Comprehensive return object with filters metadata.The returned object includes reviews, pagination, and detailed metadata with applied filters, providing excellent transparency for debugging and workflow integration.
components/trustpilot/sources/review-created/review-created.mjs (2)
4-8
: Proper webhook source structure and naming.The source correctly extends the common webhook base and uses an appropriate name "Review Created" for events about new items, following component guidelines.
17-23
: Descriptive summary generation with robust fallback handling.The summary generation creates a clear, informative message that includes star rating, consumer name, and business unit ID, with appropriate fallback values for missing data.
components/trustpilot/sources/invitation-sent/invitation-sent.mjs (3)
1-11
: LGTM!The module setup and metadata are properly configured for the invitation sent webhook source.
14-16
: LGTM!Correctly specifies the webhook event type this source handles.
17-23
: LGTM!Good use of optional chaining and fallback values for robust summary generation.
components/trustpilot/sources/invitation-failed/invitation-failed.mjs (1)
1-39
: LGTM!Well-structured webhook source with proper error message handling in the summary generation.
components/trustpilot/actions/fetch-product-reviews/fetch-product-reviews.mjs (1)
62-108
: LGTM!Well-implemented action with proper error handling, structured response, and informative summary export.
components/trustpilot/common/utils.mjs (1)
25-51
: LGTM!The parsing functions are well-structured with good use of optional chaining and sensible defaults.
Also applies to: 58-74, 81-93
components/trustpilot/common/constants.mjs (1)
1-78
: LGTM! Well-organized constants module.This constants file provides a clean, centralized location for all Trustpilot integration constants. The structure is logical with proper categorization of endpoints, events, enums, and configuration values.
components/trustpilot/app/trustpilot.app.ts (3)
103-157
: Excellent implementation of authentication and retry logic.The authentication supports both API key and OAuth methods, and the retry mechanism with exponential backoff for rate-limited requests is well-implemented. The error handling provides clear, actionable error messages.
160-259
: Well-structured API methods with comprehensive validation.The business unit and service review methods are well-implemented with:
- Proper input validation using utility functions
- Comprehensive parameter support with sensible defaults
- Correct pagination handling
- Consistent error messages
262-392
: Excellent comprehensive Trustpilot integration implementation.The product review methods mirror the service review methods appropriately, maintaining consistency. The overall implementation demonstrates:
- Consistent patterns across all method types
- Proper error handling and validation throughout
- Good use of shared utilities and constants
- Clean, maintainable code structure
This is production-ready code (pending the webhook signature validation implementation).
components/trustpilot/package.json
Outdated
"dependencies": { | ||
"@pipedream/platform": "^1.0.0" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify the @pipedream/platform dependency version.
The ^1.0.0
version constraint for @pipedream/platform
should be verified to ensure it's the correct and latest stable version for the Trustpilot integration features.
🌐 Web query:
What is the latest stable version of @pipedream/platform npm package?
💡 Result:
The latest stable version of the @pipedream/platform npm package is 3.1.0, which was published approximately one month ago as of June 2025[1][7].
Citations:
- 1: https://www.npmjs.com/package/@pipedream/platform/v/1.3.0?activeTab=readme
- 2: https://www.youtube.com/watch?v=lvTWnSAwEa8
- 3: https://pipedream.com/apps/npm/integrations/wiza/get-list-with-wiza-api-on-new-package-version-from-npm-api-int_m8s3br3r
- 4: https://github.com/npm/cli/releases
- 5: https://pipedream.com/apps/npm/integrations/plivo/speak-text-with-plivo-api-on-new-package-version-from-npm-api-int_R7sQYPqV
- 6: https://pypi.org/project/pillow/
- 7: https://www.npmjs.com/package/@pipedream/platform
- 8: Is bottleneck still maintained? SGrondin/bottleneck#207
- 9: https://www.npmjs.com/package/pipedream
- 10: https://pipedream.com/integrations/upscale-image-with-dreamstudio-stable-diffusion-api-on-npm-download-counts-from-npm-api-int_D4sAW13Z
Update @pipedream/platform to latest stable (3.1.0)
The current ^1.0.0
constraint is outdated—@pipedream/platform
v3.1.0 was released June 2025. Please bump the dependency to ensure you’re using the latest stable API.
Affected file:
- components/trustpilot/package.json (lines 16–18)
Suggested change:
"dependencies": {
- "@pipedream/platform": "^1.0.0"
+ "@pipedream/platform": "^3.1.0"
}
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"dependencies": { | |
"@pipedream/platform": "^1.0.0" | |
} | |
"dependencies": { | |
"@pipedream/platform": "^3.1.0" | |
} |
🤖 Prompt for AI Agents
In components/trustpilot/package.json around lines 16 to 18, the dependency
version for @pipedream/platform is outdated at ^1.0.0. Update the version
constraint to "^3.1.0" to use the latest stable release. This involves changing
the version string in the dependencies object to reflect the new version.
this._setWebhookId(webhook.id); | ||
|
||
// Generate and store a secret for signature validation | ||
const secret = `tp_${Math.random().toString(36).substring(2, 15)}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use cryptographically secure random generation for the secret.
Math.random()
is not cryptographically secure and should not be used for generating secrets.
Use Node.js crypto module for secure random generation:
-const secret = `tp_${Math.random().toString(36).substring(2, 15)}`;
+const crypto = await import('crypto');
+const secret = `tp_${crypto.randomBytes(16).toString('hex')}`;
Add the import at the top of the file:
import { randomBytes } from "crypto";
🤖 Prompt for AI Agents
In components/trustpilot/sources/common/webhook.mjs at line 91, replace the use
of Math.random() for generating the secret with a cryptographically secure
method. Import randomBytes from the Node.js crypto module at the top of the
file, then generate the secret using randomBytes to create a secure random
string instead of Math.random().
validateSignature(body, signature) { | ||
// TODO: Implement signature validation when Trustpilot provides it | ||
return true; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement proper signature validation.
The TODO indicates this critical security feature is not implemented. Webhook signature validation is essential to ensure requests are authentic.
Would you like me to help implement the signature validation logic or open an issue to track this security requirement?
🤖 Prompt for AI Agents
In components/trustpilot/sources/common/webhook.mjs at lines 63 to 66, the
validateSignature method currently returns true without performing any actual
validation, which is a security risk. Implement proper signature validation by
using the signature provided by Trustpilot to verify the authenticity of the
webhook payload, typically by computing a hash or HMAC of the body with a shared
secret and comparing it to the signature. If the exact validation method is
unknown, open an issue to track this security requirement and ensure it is
addressed once Trustpilot provides the necessary details.
## Overview Complete Trustpilot integration using polling approach (webhooks not supported by Trustpilot API). ## Features Implemented ### Authentication & Core App - Enhanced trustpilot.app.ts with OAuth and API key authentication - Added comprehensive API methods for reviews, products, and conversations - Support for both public and private endpoints - Proper error handling, validation, and retry logic with rate limiting ### Actions (6 total) - **fetch-service-reviews** - Get service reviews with filtering and pagination - **fetch-service-review-by-id** - Get specific service review - **fetch-product-reviews** - Get product reviews with filtering and pagination - **fetch-product-review-by-id** - Get specific product review - **reply-to-service-review** - Reply to service reviews - **reply-to-product-review** - Reply to product reviews ### Polling Sources (8 total) - **new-service-reviews** - New service reviews (public + private endpoints) - **updated-service-reviews** - Updated/revised service reviews - **new-product-reviews** - New product reviews - **updated-product-reviews** - Updated/revised product reviews - **new-service-review-replies** - New replies to service reviews - **new-product-review-replies** - New replies to product reviews - **new-conversations** - New conversations started - **updated-conversations** - Updated conversations (new messages) ### Technical Implementation - 15-minute polling intervals following Google Drive pattern - Smart deduplication by reviewId + timestamp - Business unit filtering (optional) - 24-hour lookback on first run - Comprehensive constants and utilities - Proper pagination and error handling ## API Endpoints Used - `/business-units/{businessUnitId}/reviews` (public) - `/private/business-units/{businessUnitId}/reviews` (private service) - `/private/product-reviews/business-units/{businessUnitId}/reviews` (products) - `/private/conversations` (conversations) - All reply endpoints for posting responses Addresses all requirements from https://developers.trustpilot.com/introduction/
e7cee0f
to
47cee75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (1)
components/trustpilot/app/trustpilot.app.ts (1)
499-502
: TODO: Implement webhook signature validation for security.The
validateWebhookSignature
method currently always returnstrue
, which could pose a security risk if webhook verification is required. This should be implemented before using webhooks in production.Would you like me to help implement the webhook signature validation or create an issue to track this security-critical task?
🧹 Nitpick comments (4)
components/trustpilot/app/trustpilot.app.ts (4)
34-46
: Consider logging errors in options function for better debugging.The error handling in the
businessUnitId
options function returns an empty array on error, which provides a good user experience but may mask underlying issues that developers need to be aware of.Consider adding more detailed logging:
} catch (error) { - console.error("Error fetching business units:", error); + console.error("Error fetching business units:", error.message || error); + console.error("Full error details:", JSON.stringify(error, null, 2)); return []; }
140-143
: Enhance error message with additional context.The error handling could provide more debugging information by including the endpoint and method in the error message.
Add more context to error messages:
} catch (error) { const parsedError = parseApiError(error); - throw new Error(`Trustpilot API Error: ${parsedError.message} (${parsedError.code})`); + throw new Error(`Trustpilot API Error [${method} ${endpoint}]: ${parsedError.message} (${parsedError.code})`); }
146-157
: Add exponential backoff jitter to prevent thundering herd.The retry logic uses a predictable delay pattern which could cause multiple clients to retry simultaneously. Adding jitter would distribute the load more evenly.
Add jitter to the retry delay:
if (retries > 0 && error.response?.status === HTTP_STATUS.TOO_MANY_REQUESTS) { - const delay = Math.min(RETRY_CONFIG.INITIAL_DELAY * (RETRY_CONFIG.MAX_RETRIES - retries + 1), RETRY_CONFIG.MAX_DELAY); + const baseDelay = Math.min(RETRY_CONFIG.INITIAL_DELAY * (RETRY_CONFIG.MAX_RETRIES - retries + 1), RETRY_CONFIG.MAX_DELAY); + const jitter = Math.random() * 0.5 * baseDelay; // Add up to 50% jitter + const delay = baseDelay + jitter; await sleep(delay); return this._makeRequestWithRetry(config, retries - 1); }
505-508
: Consider removing or improving the debugging method.The
authKeys
method appears to be for debugging purposes. Consider either removing it from production code or improving its implementation with better error handling.Either remove the method if it's not needed, or improve it:
- authKeys() { - console.log("Auth keys:", Object.keys(this.$auth || {})); - return Object.keys(this.$auth || {}); - }, + // For debugging authentication configuration + debugAuthKeys() { + const keys = Object.keys(this.$auth || {}); + console.log("Available auth keys:", keys); + console.log("Auth configuration status:", { + hasApiKey: !!this.$auth?.api_key, + hasOAuthToken: !!this.$auth?.oauth_access_token, + }); + return keys; + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (20)
components/trustpilot/.gitignore
(0 hunks)components/trustpilot/actions/fetch-product-review-by-id/fetch-product-review-by-id.mjs
(1 hunks)components/trustpilot/actions/fetch-product-reviews/fetch-product-reviews.mjs
(1 hunks)components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs
(1 hunks)components/trustpilot/actions/fetch-service-reviews/fetch-service-reviews.mjs
(1 hunks)components/trustpilot/actions/reply-to-product-review/reply-to-product-review.mjs
(1 hunks)components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs
(1 hunks)components/trustpilot/app/trustpilot.app.ts
(1 hunks)components/trustpilot/common/constants.mjs
(1 hunks)components/trustpilot/common/utils.mjs
(1 hunks)components/trustpilot/package.json
(1 hunks)components/trustpilot/sources/common/polling.mjs
(1 hunks)components/trustpilot/sources/new-conversations/new-conversations.mjs
(1 hunks)components/trustpilot/sources/new-product-review-replies/new-product-review-replies.mjs
(1 hunks)components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs
(1 hunks)components/trustpilot/sources/new-service-review-replies/new-service-review-replies.mjs
(1 hunks)components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs
(1 hunks)components/trustpilot/sources/updated-conversations/updated-conversations.mjs
(1 hunks)components/trustpilot/sources/updated-product-reviews/updated-product-reviews.mjs
(1 hunks)components/trustpilot/sources/updated-service-reviews/updated-service-reviews.mjs
(1 hunks)
💤 Files with no reviewable changes (1)
- components/trustpilot/.gitignore
✅ Files skipped from review due to trivial changes (1)
- components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs
🚧 Files skipped from review as they are similar to previous changes (17)
- components/trustpilot/package.json
- components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs
- components/trustpilot/actions/fetch-service-reviews/fetch-service-reviews.mjs
- components/trustpilot/actions/fetch-product-review-by-id/fetch-product-review-by-id.mjs
- components/trustpilot/actions/reply-to-product-review/reply-to-product-review.mjs
- components/trustpilot/sources/updated-service-reviews/updated-service-reviews.mjs
- components/trustpilot/actions/fetch-product-reviews/fetch-product-reviews.mjs
- components/trustpilot/sources/updated-conversations/updated-conversations.mjs
- components/trustpilot/sources/new-product-review-replies/new-product-review-replies.mjs
- components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs
- components/trustpilot/sources/new-conversations/new-conversations.mjs
- components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs
- components/trustpilot/common/utils.mjs
- components/trustpilot/sources/new-service-review-replies/new-service-review-replies.mjs
- components/trustpilot/sources/updated-product-reviews/updated-product-reviews.mjs
- components/trustpilot/common/constants.mjs
- components/trustpilot/sources/common/polling.mjs
🧰 Additional context used
🧠 Learnings (1)
components/trustpilot/app/trustpilot.app.ts (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
🔇 Additional comments (1)
components/trustpilot/app/trustpilot.app.ts (1)
2-12
: Missing RATING_SCALE import from constants.The
RATING_SCALE
constant is used on line 58 but is not imported from the constants file. This will cause a reference error.Add
RATING_SCALE
to the imports:import { BASE_URL, ENDPOINTS, DEFAULT_LIMIT, MAX_LIMIT, SORT_OPTIONS, + RATING_SCALE, RETRY_CONFIG, HTTP_STATUS, } from "../common/constants.mjs";
⛔ Skipped due to learnings
Learnt from: jcortes PR: PipedreamHQ/pipedream#14935 File: components/sailpoint/package.json:15-18 Timestamp: 2024-12-12T19:23:09.039Z Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
async getServiceReviews({ | ||
businessUnitId, | ||
stars = null, | ||
sortBy = SORT_OPTIONS.CREATED_AT_DESC, | ||
limit = DEFAULT_LIMIT, | ||
offset = 0, | ||
includeReportedReviews = false, | ||
tags = [], | ||
language = null, | ||
} = {}) { | ||
if (!validateBusinessUnitId(businessUnitId)) { | ||
throw new Error("Invalid business unit ID"); | ||
} | ||
|
||
const endpoint = buildUrl(ENDPOINTS.PRIVATE_SERVICE_REVIEWS, { businessUnitId }); | ||
const params = { | ||
stars, | ||
orderBy: sortBy, | ||
perPage: limit, | ||
page: Math.floor(offset / limit) + 1, | ||
includeReportedReviews, | ||
language, | ||
}; | ||
|
||
if (tags.length > 0) { | ||
params.tags = tags.join(","); | ||
} | ||
|
||
const response = await this._makeRequestWithRetry({ | ||
endpoint, | ||
params, | ||
}); | ||
|
||
return { | ||
reviews: response.reviews?.map(parseReview) || [], | ||
pagination: { | ||
total: response.pagination?.total || 0, | ||
page: response.pagination?.page || 1, | ||
perPage: response.pagination?.perPage || limit, | ||
hasMore: response.pagination?.hasMore || false, | ||
}, | ||
}; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider extracting common review fetching logic.
The getServiceReviews
and getProductReviews
methods (lines 240-282 and 318-360) share nearly identical logic with only the endpoint differing. This violates the DRY principle.
Extract common logic into a private method:
+ async _getReviews({
+ endpoint,
+ businessUnitId,
+ stars = null,
+ sortBy = SORT_OPTIONS.CREATED_AT_DESC,
+ limit = DEFAULT_LIMIT,
+ offset = 0,
+ includeReportedReviews = false,
+ tags = [],
+ language = null,
+ } = {}) {
+ if (businessUnitId && !validateBusinessUnitId(businessUnitId)) {
+ throw new Error("Invalid business unit ID");
+ }
+
+ const params = {
+ stars,
+ orderBy: sortBy,
+ perPage: limit,
+ page: Math.floor(offset / limit) + 1,
+ includeReportedReviews,
+ language,
+ };
+
+ if (tags.length > 0) {
+ params.tags = tags.join(",");
+ }
+
+ const response = await this._makeRequestWithRetry({
+ endpoint,
+ params,
+ });
+
+ return {
+ reviews: response.reviews?.map(parseReview) || [],
+ pagination: {
+ total: response.pagination?.total || 0,
+ page: response.pagination?.page || 1,
+ perPage: response.pagination?.perPage || limit,
+ hasMore: response.pagination?.hasMore || false,
+ },
+ };
+ },
async getServiceReviews(options = {}) {
+ const endpoint = buildUrl(ENDPOINTS.PRIVATE_SERVICE_REVIEWS, { businessUnitId: options.businessUnitId });
+ return this._getReviews({ endpoint, ...options });
},
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In components/trustpilot/app/trustpilot.app.ts between lines 240 and 282, the
getServiceReviews method shares almost identical logic with getProductReviews
(lines 318-360) except for the endpoint used. To adhere to the DRY principle,
extract the shared review fetching logic into a private method that accepts the
endpoint and parameters, then refactor both getServiceReviews and
getProductReviews to call this new method with their respective endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good suggestion by CodeRabbit to avoid duplicating code (seems it doesn't appear in the review, but Codepilot made the comment in the PR suggesting to move the common logic here into a separate method, as it is duplicated currently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GTFalcao Absolutely! CodeRabbit's suggestion to extract the common review fetching logic is spot-on. The DRY principle is crucial for maintainability, and having nearly identical code in both getServiceReviews
and getProductReviews
methods creates unnecessary duplication.
The proposed _getReviews
helper method would centralize the shared logic while keeping the specific endpoint differences in the individual methods. This would make the codebase more maintainable and reduce the risk of inconsistencies if changes need to be made to the review fetching logic in the future.
🐰✨
^.^
( o.o )
^ <
🧠 Learnings used
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
… in Trustpilot integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (2)
components/trustpilot/app/trustpilot.app.ts (2)
105-120
: Authentication header method needs validation.The authentication method should validate that at least one authentication method is configured to provide clearer error messages.
242-284
: Consider extracting common review fetching logic.The
getServiceReviews
andgetProductReviews
methods share nearly identical logic with only the endpoint differing. This violates the DRY principle.
🧹 Nitpick comments (4)
components/trustpilot/sources/updated-product-reviews/updated-product-reviews.mjs (1)
9-9
: Consider removing redundant "New" prefix from the name.Based on Pipedream component guidelines, the "New" prefix is only required when emits are limited to new items. Since this source emits events for updated items, the name could be simplified to "Updated Product Reviews" to avoid redundancy.
- name: "New Updated Product Reviews", + name: "Updated Product Reviews",components/trustpilot/sources/updated-conversations/updated-conversations.mjs (1)
9-9
: Consider removing redundant "New" prefix from the name.Similar to the product reviews source, this name could be simplified to "Updated Conversations" to avoid redundancy, following Pipedream guidelines for sources that emit updated items rather than new items.
- name: "New Updated Conversations", + name: "Updated Conversations",components/trustpilot/sources/updated-service-reviews/updated-service-reviews.mjs (1)
9-9
: Consider removing redundant "New" prefix from the name.Consistent with the other updated sources, this name could be simplified to "Updated Service Reviews" to follow Pipedream guidelines for sources that emit updated items.
- name: "New Updated Service Reviews", + name: "Updated Service Reviews",components/trustpilot/sources/common/polling.mjs (1)
116-137
: Error handling in fetchItems could be improved.The method handles different response formats well, but the error logging exposes potentially sensitive information and should be more generic in production.
Consider sanitizing error logs to avoid exposing sensitive information:
} catch (error) { - console.error(`Error fetching items with ${method}:`, error); + console.error(`Error fetching items with ${method}:`, error.message); throw error; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (19)
components/trustpilot/actions/fetch-product-review-by-id/fetch-product-review-by-id.mjs
(1 hunks)components/trustpilot/actions/fetch-product-reviews/fetch-product-reviews.mjs
(1 hunks)components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs
(1 hunks)components/trustpilot/actions/fetch-service-reviews/fetch-service-reviews.mjs
(1 hunks)components/trustpilot/actions/reply-to-product-review/reply-to-product-review.mjs
(1 hunks)components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs
(1 hunks)components/trustpilot/app/trustpilot.app.ts
(1 hunks)components/trustpilot/common/constants.mjs
(1 hunks)components/trustpilot/common/utils.mjs
(1 hunks)components/trustpilot/package.json
(1 hunks)components/trustpilot/sources/common/polling.mjs
(1 hunks)components/trustpilot/sources/new-conversations/new-conversations.mjs
(1 hunks)components/trustpilot/sources/new-product-review-replies/new-product-review-replies.mjs
(1 hunks)components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs
(1 hunks)components/trustpilot/sources/new-service-review-replies/new-service-review-replies.mjs
(1 hunks)components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs
(1 hunks)components/trustpilot/sources/updated-conversations/updated-conversations.mjs
(1 hunks)components/trustpilot/sources/updated-product-reviews/updated-product-reviews.mjs
(1 hunks)components/trustpilot/sources/updated-service-reviews/updated-service-reviews.mjs
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (12)
- components/trustpilot/package.json
- components/trustpilot/actions/reply-to-service-review/reply-to-service-review.mjs
- components/trustpilot/actions/reply-to-product-review/reply-to-product-review.mjs
- components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs
- components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs
- components/trustpilot/sources/new-product-review-replies/new-product-review-replies.mjs
- components/trustpilot/actions/fetch-service-reviews/fetch-service-reviews.mjs
- components/trustpilot/sources/new-service-review-replies/new-service-review-replies.mjs
- components/trustpilot/actions/fetch-product-reviews/fetch-product-reviews.mjs
- components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs
- components/trustpilot/sources/new-conversations/new-conversations.mjs
- components/trustpilot/common/constants.mjs
🧰 Additional context used
🧠 Learnings (6)
components/trustpilot/sources/updated-product-reviews/updated-product-reviews.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trustpilot/sources/updated-conversations/updated-conversations.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trustpilot/common/utils.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14229
File: components/americommerce/actions/update-customer/update-customer.mjs:89-94
Timestamp: 2024-10-08T16:42:59.225Z
Learning: When defining boolean properties in AmeriCommerce components (e.g., in `update-customer.mjs`), ensure that the label and description are consistent and clearly indicate the intent, especially when using negations like "No Account", to avoid confusion.
components/trustpilot/sources/updated-service-reviews/updated-service-reviews.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trustpilot/sources/common/polling.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The `processTimerEvent` method in the `components/salesforce_rest_api/sources/common.mjs` file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trustpilot/app/trustpilot.app.ts (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15436
File: components/printful/printful.app.mjs:55-63
Timestamp: 2025-01-29T22:59:38.825Z
Learning: Console.log statements should be removed before merging PRs to maintain code quality and prevent potential security risks from exposing sensitive information in logs.
🧬 Code Graph Analysis (2)
components/trustpilot/sources/updated-product-reviews/updated-product-reviews.mjs (8)
components/trustpilot/common/constants.mjs (4)
SOURCE_TYPES
(102-108)SOURCE_TYPES
(102-108)SORT_OPTIONS
(58-65)SORT_OPTIONS
(58-65)components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs (4)
stars
(32-32)consumerName
(33-33)productName
(34-34)businessUnit
(35-35)components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs (3)
stars
(33-33)consumerName
(34-34)businessUnit
(35-35)components/trustpilot/sources/updated-service-reviews/updated-service-reviews.mjs (3)
stars
(32-32)consumerName
(33-33)businessUnit
(34-34)components/trustpilot/sources/new-product-review-replies/new-product-review-replies.mjs (2)
consumerName
(63-63)productName
(62-62)components/trustpilot/sources/new-service-review-replies/new-service-review-replies.mjs (1)
consumerName
(62-62)components/trustpilot/sources/new-conversations/new-conversations.mjs (1)
businessUnit
(36-36)components/trustpilot/sources/updated-conversations/updated-conversations.mjs (1)
businessUnit
(36-36)
components/trustpilot/actions/fetch-product-review-by-id/fetch-product-review-by-id.mjs (2)
components/trustpilot/actions/fetch-service-review-by-id/fetch-service-review-by-id.mjs (1)
review
(32-35)components/trustpilot/common/utils.mjs (1)
error
(199-201)
🪛 Biome (1.9.4)
components/trustpilot/common/utils.mjs
[error] 35-35: Unexpected control character in a regular expression.
Control characters are unusual and potentially incorrect inputs, so they are disallowed.
(lint/suspicious/noControlCharactersInRegex)
[error] 35-35: Unexpected control character in a regular expression.
Control characters are unusual and potentially incorrect inputs, so they are disallowed.
(lint/suspicious/noControlCharactersInRegex)
[error] 35-35: Unexpected control character in a regular expression.
Control characters are unusual and potentially incorrect inputs, so they are disallowed.
(lint/suspicious/noControlCharactersInRegex)
[error] 35-35: Unexpected control character in a regular expression.
Control characters are unusual and potentially incorrect inputs, so they are disallowed.
(lint/suspicious/noControlCharactersInRegex)
[error] 35-35: Unexpected control character in a regular expression.
Control characters are unusual and potentially incorrect inputs, so they are disallowed.
(lint/suspicious/noControlCharactersInRegex)
[error] 35-35: Unexpected control character in a regular expression.
Control characters are unusual and potentially incorrect inputs, so they are disallowed.
(lint/suspicious/noControlCharactersInRegex)
🔇 Additional comments (31)
components/trustpilot/actions/fetch-product-review-by-id/fetch-product-review-by-id.mjs (2)
1-18
: LGTM! Well-structured action component.The action follows Pipedream component best practices with proper imports, metadata, and prop definitions. The use of
propDefinition
forreviewId
ensures consistency with the app's prop definitions.
19-39
: Good error handling and structured response.The implementation properly handles errors with descriptive messages and returns well-structured data with both the review content and metadata. The metadata includes useful information like the reviewId and timestamp.
components/trustpilot/sources/updated-product-reviews/updated-product-reviews.mjs (1)
15-39
: LGTM! Consistent implementation with proper fallbacks.The source correctly implements the required methods and provides robust fallback values for missing data in the summary generation. The polling parameters and source type are appropriately configured.
components/trustpilot/sources/updated-conversations/updated-conversations.mjs (1)
31-40
: LGTM! Comprehensive fallback logic for summary generation.The summary generation method handles various data structures with multiple fallback options for participant names, subjects, and message counts. This provides robust event summaries even when data is incomplete.
components/trustpilot/sources/updated-service-reviews/updated-service-reviews.mjs (1)
15-38
: LGTM! Consistent implementation across review sources.The source follows the same pattern as the product reviews source with appropriate method implementations and fallback handling in the summary generation.
components/trustpilot/common/utils.mjs (8)
6-18
: LGTM! Comprehensive HTML escaping implementation.The HTML escaping function properly handles all common XSS vectors including forward slashes and single quotes. The regex and replacement map are well-defined for security.
26-43
: Good sanitization with appropriate control character handling.The function properly removes harmful control characters while preserving newlines and tabs. The ESLint disable comment is appropriate here as the regex intentionally uses control characters for sanitization purposes.
51-65
: LGTM! Previous review feedback has been addressed.The URL building function now uses split/join instead of string replace to avoid regex issues and properly encodes parameter values with
encodeURIComponent
. This addresses the previous review concern about handling special characters.
72-100
: Well-structured data parsing with security considerations.The review parsing function properly applies HTML escaping to user-generated content fields while preserving structured data. The nested object handling is appropriate.
151-170
: LGTM! ID validation addresses previous feedback.The validation functions now properly enforce the 24-character hexadecimal format for MongoDB ObjectIDs, addressing the previous review comment about more specific validation requirements.
177-190
: Good parameter filtering logic.The function properly filters out null, undefined, and empty string values to clean up API requests.
197-216
: Comprehensive error parsing with fallbacks.The error parsing function handles both API response errors and general errors with appropriate fallback values and structured error information.
223-225
: Simple and effective utility function.The sleep function provides a clean promise-based delay mechanism for retry logic.
components/trustpilot/sources/common/polling.mjs (7)
1-17
: Well-structured documentation and rationale.The comprehensive documentation explaining the choice of polling over webhooks provides clear reasoning for the architectural decision. The rationale covers reliability, simplicity, data consistency, and authentication compatibility - all valid technical considerations for a Pipedream integration.
18-36
: Props configuration follows Pipedream best practices.The props structure correctly implements:
- Trustpilot app dependency
- Database service for state persistence
- Timer with configurable intervals from constants
- Optional business unit filtering with proper prop definition reference
37-64
: State management methods are well-implemented.The state management follows good patterns:
- Clear separation of concerns with private methods
- Proper cleanup mechanism for seen items to prevent memory bloat
- Sensible default retention period (72 hours)
- Efficient cleanup using timestamp-based filtering
65-80
: Abstract method pattern correctly implemented.The abstract methods follow the pattern seen in retrieved learnings where base classes intentionally leave methods unimplemented to enforce subclass implementation. The
getPollingMethod()
properly throws an error whilegetSourceType()
andgetPollingParams()
provide sensible defaults.
81-115
: Item processing logic is robust.The deduplication and metadata generation logic correctly:
- Handles different source types (new vs updated)
- Uses appropriate timestamps for different event types
- Generates unique keys combining ID and timestamp
- Provides extensible summary generation
138-183
: Core polling logic is well-architected.The
pollForItems
method implements solid polling patterns:
- Proper lookback handling for first runs
- Comprehensive deduplication using seen items tracking
- Chronological emission (oldest first) for proper event ordering
- State persistence and cleanup
- Good error handling and logging
184-188
: Simple and effective run method.The run method correctly delegates to the polling logic, keeping the interface clean and focused.
components/trustpilot/app/trustpilot.app.ts (11)
1-26
: Comprehensive imports and dependencies.The imports cover all necessary utilities and constants, showing good separation of concerns between the app file and utility modules.
30-102
: Well-structured prop definitions with dynamic options.The prop definitions are comprehensive and follow Pipedream best practices:
- Proper type definitions and validation
- Dynamic options for business units
- Sensible defaults and optional flags
- Good error handling in async options
122-146
: Base request method is well-implemented.The
_makeRequest
method correctly handles:
- URL construction and header management
- Parameter formatting using utility functions
- Timeout configuration
- Error parsing and meaningful error messages
148-159
: Retry logic follows best practices.The retry wrapper correctly implements exponential backoff for rate limiting (429 errors) with proper delay calculation and maximum retry limits.
161-183
: Business unit methods are robust.Both methods include proper validation using utility functions and handle pagination correctly. The search method safely handles missing response properties.
185-239
: Public review methods are well-implemented.The public methods correctly:
- Validate input parameters
- Handle pagination with proper offset-to-page conversion
- Use retry logic for reliability
- Parse responses consistently
286-326
: Service review methods include proper validation.The methods correctly validate inputs and implement message sanitization for replies. The warning about truncation is helpful for users.
328-407
: Product review methods mirror service review patterns.The product review methods follow the same patterns as service reviews, maintaining consistency across the API. The validation and sanitization logic is properly implemented.
409-476
: Conversation methods are comprehensive.The conversation methods provide full CRUD operations with proper validation, pagination, and message sanitization consistent with other reply methods.
478-521
: Webhook management methods are complete.The webhook methods provide comprehensive management capabilities with proper validation for URLs, events, and IDs. The optional business unit filtering is well-implemented.
523-547
: Webhook signature validation is properly implemented.The webhook signature validation correctly implements HMAC-SHA256 with constant-time comparison to prevent timing attacks. This addresses the security concern from previous reviews.
The implementation properly:
- Validates required parameters
- Handles both string and object payloads
- Uses crypto.timingSafeEqual for security
- Follows Trustpilot's webhook signature format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
components/freshdesk/actions/add-note-to-ticket/add-note-to-ticket.mjs
(1 hunks)components/freshdesk/freshdesk.app.mjs
(1 hunks)
🔇 Additional comments (4)
components/freshdesk/freshdesk.app.mjs (1)
269-278
: LGTM! Method follows established patterns.The
addNoteToTicket
method is well-implemented and consistent with other methods in the file. It properly uses the internal_makeRequest
method and follows the established parameter destructuring pattern.components/freshdesk/actions/add-note-to-ticket/add-note-to-ticket.mjs (3)
1-11
: LGTM! Proper imports and metadata structure.The imports are correct, the key follows the expected naming pattern, and the documentation link is helpful for users.
63-65
: LGTM! Proper input validation.The validation correctly checks for empty or whitespace-only content and throws an appropriate error with a clear message.
67-94
: LGTM! Well-structured main logic.The implementation properly handles optional parameters, performs appropriate type conversions, and provides good user feedback through the summary message.
body: { | ||
type: "string", | ||
label: "Note Body", | ||
description: "Content of the note in HTML format", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Mark the body prop as required.
The body prop should be marked as required since the validation logic treats it as mandatory.
body: {
type: "string",
label: "Note Body",
description: "Content of the note in HTML format",
+ required: true,
},
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
body: { | |
type: "string", | |
label: "Note Body", | |
description: "Content of the note in HTML format", | |
}, | |
body: { | |
type: "string", | |
label: "Note Body", | |
description: "Content of the note in HTML format", | |
required: true, | |
}, |
🤖 Prompt for AI Agents
In components/freshdesk/actions/add-note-to-ticket/add-note-to-ticket.mjs
between lines 18 and 22, the body property is missing a required flag. Add a
required: true attribute to the body property definition to ensure it is treated
as mandatory in validation.
c79d7f3
to
404d68f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @seynadio thanks for your contribution!
I've left a few comments that we need to adjust before moving forward. In some cases the same adjustment should be made in all components that behave in the same way.
name: "Fetch Product Review by ID", | ||
description: "Retrieves detailed information about a specific product review on Trustpilot. Use this action to get comprehensive data about a single product review, including customer feedback, star rating, review text, and metadata. Perfect for analyzing individual customer experiences, responding to specific feedback, or integrating review data into your customer service workflows. [See the documentation](https://developers.trustpilot.com/product-reviews-api#get-private-product-review)", | ||
version: "0.0.1", | ||
publishedAt: "2025-07-18T00:00:00.000Z", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the 'publishedAt' line from all the components that have it
}, | ||
}; | ||
} catch (error) { | ||
throw new Error(`Failed to fetch product review: ${error.message}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we shouldn't be try/catching here, because @pipedream/platform
's axios already handles error responses and emits metadata for the request and response - this would make it harder to debug. The same applies for all components using a try/catch here in the request method
} = this; | ||
|
||
if (!message || message.trim().length === 0) { | ||
throw new Error("Reply message cannot be empty"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new Error("Reply message cannot be empty"); | |
throw new ConfigurationError("Reply message cannot be empty"); |
This should be a ConfigurationError (imported from @pipedream/platform
async getServiceReviews({ | ||
businessUnitId, | ||
stars = null, | ||
sortBy = SORT_OPTIONS.CREATED_AT_DESC, | ||
limit = DEFAULT_LIMIT, | ||
offset = 0, | ||
includeReportedReviews = false, | ||
tags = [], | ||
language = null, | ||
} = {}) { | ||
if (!validateBusinessUnitId(businessUnitId)) { | ||
throw new Error("Invalid business unit ID"); | ||
} | ||
|
||
const endpoint = buildUrl(ENDPOINTS.PRIVATE_SERVICE_REVIEWS, { businessUnitId }); | ||
const params = { | ||
stars, | ||
orderBy: sortBy, | ||
perPage: limit, | ||
page: Math.floor(offset / limit) + 1, | ||
includeReportedReviews, | ||
language, | ||
}; | ||
|
||
if (tags.length > 0) { | ||
params.tags = tags.join(","); | ||
} | ||
|
||
const response = await this._makeRequestWithRetry({ | ||
endpoint, | ||
params, | ||
}); | ||
|
||
return { | ||
reviews: response.reviews?.map(parseReview) || [], | ||
pagination: { | ||
total: response.pagination?.total || 0, | ||
page: response.pagination?.page || 1, | ||
perPage: response.pagination?.perPage || limit, | ||
hasMore: response.pagination?.hasMore || false, | ||
}, | ||
}; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good suggestion by CodeRabbit to avoid duplicating code (seems it doesn't appear in the review, but Codepilot made the comment in the PR suggesting to move the common logic here into a separate method, as it is duplicated currently)
...common, | ||
key: "trustpilot-new-conversations", | ||
name: "New Conversations", | ||
description: "Emit new event when a new conversation is started on Trustpilot. This source polls the Trustpilot API every 15 minutes to detect new customer-business conversations. Each event contains conversation details including participants, subject, business unit, and creation timestamp. Useful for tracking customer inquiries, support requests, and maintaining real-time communication with customers.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the 'polls the Trustpilot API every 15 minutes' from all the component descriptions it's in, since this time is configurable within the source
Summary
Summary by CodeRabbit
New Features
Chores